Skip to content

fix slf4j nop warnings #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DMarinhoCodacy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix slf4j nop warnings #544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ name := "codacy-coverage-reporter"
// Runtime dependencies
libraryDependencies ++= Seq(
"com.github.alexarchambault" %% "case-app" % "2.1.0-M28",
"org.wvlet.airframe" %% "airframe-log" % "24.6.0"
"org.wvlet.airframe" %% "airframe-log" % "24.6.0",
"org.slf4j" % "slf4j-nop" % "1.7.36"

@gemini-code-assist gemini-code-assist Bot Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using slf4j-nop silences the SLF4J warnings, but it also silently discards all log messages from third-party libraries that rely on SLF4J (such as org.eclipse.jgit). Since this application uses airframe-log (which is built on top of java.util.logging), a better approach is to use slf4j-jdk14. This routes all SLF4J logging calls to java.util.logging, allowing airframe-log to capture, format, and output them consistently, preserving valuable debugging information.

  "org.slf4j" % "slf4j-jdk14" % "1.7.36"

@codacy-production codacy-production Bot Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

Suggestion: Including slf4j-nop will silence all log output for the project. If you need to see logs, consider using slf4j-simple or logback-classic instead. If the goal is only to suppress warnings during testing, move this dependency to the Test scope.

)

// Test dependencies
Expand Down