go.mod, go.sum: upgrade to remove old dependencies#3836
Open
jba wants to merge 1 commit intocockroachdb:masterfrom
Open
go.mod, go.sum: upgrade to remove old dependencies#3836jba wants to merge 1 commit intocockroachdb:masterfrom
jba wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Upgrade cobra, prometheus and golang.org/x/perf to the latest versions. This removes a lot of clutter from go.sum, including the spiral of old cloud.google.com/go versions. Even though these old versions aren't part of the build, the go command is forced to fetch their go.mod files.
Member
|
This change is |
nicktrav
reviewed
Aug 12, 2024
| github.com/prometheus/common v0.32.1 // indirect | ||
| github.com/prometheus/procfs v0.7.3 // indirect | ||
| github.com/rogpeppe/go-internal v1.9.0 // indirect | ||
| github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect |
Contributor
There was a problem hiding this comment.
Where is this dep coming from, and what is it used for?
Author
There was a problem hiding this comment.
go mod why says:
github.com/cockroachdb/pebble
github.com/prometheus/client_golang/prometheus
github.com/prometheus/common/expfmt
github.com/munnerz/goautoneg
The expfmt package uses it twice:
- https://github.com/prometheus/common/blob/main/expfmt/encode.go#L67
- https://github.com/prometheus/common/blob/main/expfmt/encode.go#L100
ParseAccept parses an accept header:
https://github.com/munnerz/goautoneg/blob/master/autoneg.go#L93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade cobra, prometheus and golang.org/x/perf to the latest versions. This removes a lot of clutter from go.sum, including the spiral of old cloud.google.com/go versions. Even though these old versions aren't part of the build, the go command is forced to fetch their go.mod files.