Conversation
|
This is neat stuff. What's the use case driving this? Curious what problem you're solving with it. |
Contributor
Author
|
It's useful when multiple processes need to coordinate exclusive access to a shared resource, using CockroachDB as the backing store for time-based leases. |
BramGruneir
approved these changes
Mar 9, 2026
Member
BramGruneir
left a comment
BramGruneir
left a comment
There was a problem hiding this comment.
I tried to look at the changes you made, and not the rest of the code since we've already vetted it.
My only nit would be the formatting of the SQL files. Could you use a formatter on them?
@BramGruneir reviewed 11 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on sravotto).
Package lease coordinates global, singleton activities using exclusive, time-based locks on named resources backed by CockroachDB. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package lease coordinates global, singleton activities using exclusive, time-based locks on named resources backed by CockroachDB.
This change is