Skip to content

Conversation

@blathers-crl
Copy link

@blathers-crl blathers-crl bot commented Feb 10, 2026

Backport 1/1 commits from #162546 on behalf of @jeffswenson.


Previously, the checkpoint logic lived in side of the per-span loop. This could result in updating a checkpoint O(spans) times when there is a lagging span in the frontier. This has always been slightly sub-optimal, because we may advance the high water mark multiple times while processing spans, but its particularly costly as of 25.4 because we save individual frontier changes.

Release note (performance improvement): improved the performance on changefeed checkpoint when changefeeds are lagging. Informs: #158913


Release justification: fixes a checkpoint performance regression introduced in 25.4.

Previously, the checkpoint logic lived in side of the per-span loop.
This could result in updating a checkpoint O(spans) times when there is
a lagging span in the frontier. This has always been slightly
sub-optimal, because we may advance the high water mark multiple times
while processing spans, but its particularly costly as of 25.4 because
we save individual frontier changes.

Release note (performance improvement): improved the performance on
changefeed checkpoint when changefeeds are lagging.
Informs: #158913
@blathers-crl blathers-crl bot requested a review from a team as a code owner February 10, 2026 15:42
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-25.4-162546 branch from 1461c9e to 2b535e7 Compare February 10, 2026 15:42
@blathers-crl blathers-crl bot requested review from jeffswenson and removed request for a team February 10, 2026 15:42
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Feb 10, 2026
@blathers-crl blathers-crl bot requested a review from andyyang890 February 10, 2026 15:42
@blathers-crl
Copy link
Author

blathers-crl bot commented Feb 10, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-cdc labels Feb 10, 2026
@blathers-crl
Copy link
Author

blathers-crl bot commented Feb 10, 2026

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl
Copy link
Author

blathers-crl bot commented Feb 10, 2026

✅ PR #163282 is compliant with backport policy

Confidence: high
Critical bug criteria met: [Significant performance regressions]
Backward compatible: true
Explanation: The pull request addresses a significant performance regression regarding the handling of changefeed checkpointing, which meets the critical bug criteria under 'Significant performance regressions'. The PR body includes a 'Release justification:' line that clearly describes the regression and the performance improvement brought by the change, therefore exempting it from feature flag requirements. The file changed is a production file ('pkg/ccl/changefeedccl/changefeed_processors.go'), and it's related to core changefeed functionality. The changelog entry also labels it as a 'performance improvement.' The compliance is further supported by specifics about improving performance during conditions where the changefeed may lag, aligning convincingly with the PR's claimed performance enhancements.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andyyang890 andyyang890 removed the request for review from jeffswenson February 10, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-cdc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants