feat: allow multiple date formats in frontmatter published date#1134
Open
tglman wants to merge 3 commits intocobalt-org:masterfrom
Open
feat: allow multiple date formats in frontmatter published date#1134tglman wants to merge 3 commits intocobalt-org:masterfrom
tglman wants to merge 3 commits intocobalt-org:masterfrom
Conversation
Member
|
Is there a reason we shouldn't fix this in liquid instead? |
Contributor
Author
|
Hi, I just opened a PR to fix this in liquid: cobalt-org/liquid-rust#500, that will fix the regression anyway this PR also include the support of multiple date formats, like date formats without time, which I think it does make sense in term of blog posts. Bye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
As the description say, this allow to have multiple date formats for the published_date in the front matter, and still use the the liquid date time parsing, I started this implementation because of a regression on the liquid serde implementation of DateTime, if you
cargo updatethe dependencies existing sites may fail to parse because the serde deserialization of DateTime require now the milliseconds, I'm going to open an issue on liquid for this(if not already there).