Adding dockerfile for pyne vs Python/moab5.0/dagmc#4
Adding dockerfile for pyne vs Python/moab5.0/dagmc#4bam241 wants to merge 16 commits intocnerg:mainfrom
Conversation
|
Perhaps we should add entries to the README to catalog what we have? |
gonuke
left a comment
There was a problem hiding this comment.
Some changes, it maybe it depends on the last comment about dev vs stable
pyne_ubuntu.16.04.py2.dockerfile
Outdated
| && cd moab \ | ||
| && git clone https://bitbucket.org/fathomteam/moab \ | ||
| && cd moab \ | ||
| && git checkout -b Version5.0 origin/Version5.0 \ |
There was a problem hiding this comment.
Yes my bad, I tried Version5.1, but it does not exist as they named it Version5.1.0...
updating that...
pyne_ubuntu.16.04.py2.dockerfile
Outdated
| && cd .. \ | ||
| && mkdir build \ | ||
| && cd build \ | ||
| && ../moab/configure --enable-shared --enable-dagmc --enable-pymoab \ |
pyne_ubuntu.16.04.py3.dockerfile
Outdated
| && git checkout kkiesling-python3 \ | ||
| && python3 setup.py install --user \ | ||
| --moab $HOME/opt/moab --dagmc $HOME/opt/dagmc --clean | ||
| ENV PYTHONPATH=$HOME/opt/moab/lib/python3.6/site-packages/ |
There was a problem hiding this comment.
Couldn’t this path change as python 3.x changes?
pyne_ubuntu.16.04.py3.dockerfile
Outdated
| # Install PyNE | ||
| RUN pip3 install cython --force-reinstall | ||
| RUN cd $HOME/opt \ | ||
| && git clone https://github.com/bam241/pyne.git \ |
There was a problem hiding this comment.
Not sure we want to commit these with such non-standard repos and branches.
Maybe we can have a development folder and a production folder. The former is for sharing things that are specialized and non-standard (hopefully only in transition) and the latter for more stable.
There was a problem hiding this comment.
yes of course, sorry about that that was a copy paste of the dockerfile I was using to test pyne stuff... I forgot to change it...
There was a problem hiding this comment.
@gonuke do we want to rely on cnerg forks (when we have them) or main repos ?
|
this won't work yet on pyne/develop branch as long as the |
|
@gonuke what do you think about an architecture like this ? |
|
I am thinking that we could tag all of them with the same name, to avoid keeping all the temporary ones in memory, it could also allow users to build a big container with multiple of our softwares/dependencies |
Add blank line at end to see if DH triggers on py3
No description provided.