Skip to content

fix: cache countLines. add comments.#34

Merged
AsterDY merged 1 commit intomainfrom
fix/countlines
Jun 15, 2025
Merged

fix: cache countLines. add comments.#34
AsterDY merged 1 commit intomainfrom
fix/countlines

Conversation

@Hoblovski
Copy link
Collaborator

What type of PR is this?

经过 perf 分析,export 很慢的原因是重复对同样的 fileContent 调用 countLinesCached。
但是这个不是 cache 而是内存 pool,所以澄清了这一点并且增加了 cache。

人眼看 json 基本正确,但是无法比对因为 abcoder 输出不稳定(见 issue

Before

Screenshot from 2025-06-10 20-01-14

After

Screenshot from 2025-06-10 20-02-17

端到端加速 20%

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@AsterDY AsterDY merged commit ab2b573 into main Jun 15, 2025
2 checks passed
@Hoblovski Hoblovski deleted the fix/countlines branch July 29, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants