fix: getFileStruct null pointer exception#130
Merged
AsterDY merged 1 commit intocloudwego:mainfrom Dec 13, 2025
Merged
Conversation
|
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a null pointer exception in the GetFileStructure function that occurred when an invalid file path was provided.
Key Changes
- Modified error handling in
GetFileStructureto return a newGetFileStructRespobject instead of trying to set theErrorfield on a nilresppointer
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Fixes #129 |
Hoblovski
approved these changes
Dec 10, 2025
Collaborator
|
Looks great. Would you sign the CLA so we can merge the PR? |
Contributor
Author
|
Thank you for your affirmation, I have already signed the cla now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I enter a FilePath that does not meet the specified rules, resp will be a null pointer error.