Conversation
using kubebuilder: ``` $ go mod init github.com/cloudscale-ch/cluster-api-provider-cloudscale $ kubebuilder init --domain cluster.x-k8s.io --owner "cloudscale.ch" --plugins go/v4,autoupdate/v1-alpha,grafana/v1-alpha --project-name cluster-api-provider-cloudscale ```
using kubebuilder: ``` $ kubebuilder create api --group infrastructure --version v1beta2 --kind CloudscaleCluster $ kubebuilder create api --group infrastructure --version v1beta2 --kind CloudscaleMachine $ kubebuilder create api --group infrastructure --version v1beta2 --kind CloudscaleMachineTemplate ```
using kubebuilder: ``` $ kubebuilder create webhook --group infrastructure --version v1beta2 --kind CloudscaleCluster --defaulting --programmatic-validation $ kubebuilder create webhook --group infrastructure --version v1beta2 --kind CloudscaleMachine --defaulting --programmatic-validation $ kubebuilder create webhook --group infrastructure --version v1beta2 --kind CloudscaleMachineTemplate --defaulting --programmatic-validation ```
[according to docs](https://cluster-api.sigs.k8s.io/developer/core/tilt.html).
mweibel
force-pushed
the
scaffolding
branch
3 times, most recently
from
dad3bda to
7c3bd5e
Compare
- remove custom linter - not much benefit for increased complexity - disable automatic e2e tests for now, set them to manual. e2e tests don't work yet since we have no actual code in the controller yet. - only run push lint/test on main branch to avoid running two actions (pull_request and push) on each push to a PR branch. - ensure to clone with repo access token due to setting the repository temporarily private - update readme to incorporate review feedback and make things more clear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scaffolding commands used:
$ go mod init github.com/cloudscale-ch/cluster-api-provider-cloudscale $ kubebuilder init --domain cluster.x-k8s.io --owner "cloudscale.ch" --plugins go/v4,autoupdate/v1-alpha,grafana/v1-alpha --project-name cluster-api-provider-cloudscale $ kubebuilder create api --group infrastructure --version v1beta2 --kind CloudscaleCluster $ kubebuilder create api --group infrastructure --version v1beta2 --kind CloudscaleMachine $ kubebuilder create api --group infrastructure --version v1beta2 --kind CloudscaleMachineTemplate $ kubebuilder create webhook --group infrastructure --version v1beta2 --kind CloudscaleCluster --defaulting --programmatic-validation $ kubebuilder create webhook --group infrastructure --version v1beta2 --kind CloudscaleMachine --defaulting --programmatic-validation $ kubebuilder create webhook --group infrastructure --version v1beta2 --kind CloudscaleMachineTemplate --defaulting --programmatic-validationThen setup README and tilt provider yaml according to reference docs.
Custom golangci-lint linter has been removed because there isn't an easy way to use the golangci-lint action with custom plugins and I don't see a huge benefit to that specific linter.
Disabled automatic e2e tests because they don't currently work yet because there's no actual code yet.