Fixed ugly default borders on WordPress table blocks#2222
Merged
tylersticka merged 2 commits intomainfrom Feb 5, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: d7621a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for cloudfour-patterns ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
Author
|
Note: One CI job is failing, but it seems to be due to a browser process issue? |
Paul-Hebert
approved these changes
Feb 5, 2025
Contributor
There was a problem hiding this comment.
Thanks WP! 🧌
(Actually, thank you @tylersticka!)
That CI error looks familiar. Let me see if I can dig up how to fix it. (Not a blocker)
spaceninja
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
At some point, WordPress shipped an update that applied a default
border-widthon table blocktdandthelements unless a block style was applied.This adds
border-width: 0to those elements by default so they'll be consistent with our table component again.Screenshots
Testing
For whatever reason, this issue isn't symptomatic with our imported Gutenberg styles. But it wouldn't hurt to check our stories for the WordPress table block on the deploy preview to make sure this didn't introduce regressions.