Skip to content

Add canary instance step test#1476

Merged
ctlong merged 2 commits intocloudfoundry:developfrom
Samze:canary_step_test
May 7, 2025
Merged

Add canary instance step test#1476
ctlong merged 2 commits intocloudfoundry:developfrom
Samze:canary_step_test

Conversation

@Samze
Copy link
Contributor

@Samze Samze commented Mar 5, 2025

What is this change about?

Adds test for Canary steps.

Please provide contextual information.

What version of cf-deployment have you run this cf-acceptance-test change against?

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

Integration of CF CLI and CAPI.

How many more (or fewer) seconds of runtime will this change introduce to CATs?

~2mins

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

@Samze Samze force-pushed the canary_step_test branch from cf78f39 to 33ee715 Compare March 5, 2025 21:10
Copy link
Member

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samze Samze marked this pull request as ready for review March 19, 2025 16:23
@Samze
Copy link
Contributor Author

Samze commented Mar 19, 2025

This is now included in https://github.com/cloudfoundry/cf-deployment/releases/tag/v48.5.0 and ready for review

@Samze Samze force-pushed the canary_step_test branch from ef3e65b to 4acac59 Compare April 29, 2025 21:07
@Samze Samze requested a review from ctlong April 29, 2025 21:08
@Samze Samze removed their assignment May 5, 2025
@Samze Samze requested a review from ctlong May 7, 2025 01:52
@ctlong ctlong merged commit 48768b9 into cloudfoundry:develop May 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants