Open
Conversation
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes noisy test output in the agents suite — DNS lookup failures and Durable Object invalidation errors that obscured real failures.
Changes
DNS lookup failures (eliminated)
tests/agents/mcp.ts— MockconnectToServeronTestHttpMcpDedupAgentto prevent real network calls tomcp.example.comtests/mcp/client-manager.test.ts— MockconnectToServerin the restore+wait integration test to prevent calls totest.example.comDurable Object invalidation (eliminated)
src/index.ts—_scheduleNextAlarm()now callsdeleteAlarm()when no schedules remain. Previously, cancelling the last schedule left an orphaned workerd alarm.tests/schedule.test.ts— Cancel all interval schedules at end of tests (9 tests were leaving alarms active)tests/message-handling.test.ts,tests/basepath.test.ts,tests/observability.test.ts— AddcloseAndWaitto WebSocket teardown so close handlers finish before module transitionstests/mcp/transports/streamable-http.test.ts— Cancel unclosed SSE readers at end of testsRemaining stderr noise
Intentional (tests exercising error paths, all have matching assertions):
state.test.ts— state validation rejection, duplicate hook guardsession/provider.test.ts— input validation (negative limit/offset)workflow-error-reporting.test.ts— workflow throw/reject/error-reporting pathsUnintentional (miniflare mock limitations, no assertions):
workflow.test.ts—Engine was never started/instance.not_foundfrom miniflare's workflow binding when tests write to SQLite without creating real workflow instances