Fix pre-existing compilation warnings and lint issues#3860
Merged
Conversation
6 tasks
Use backtick-apostrophe (\`symbol') for Lisp symbol references in
docstrings instead of plain single quotes ('symbol), which triggers
byte-compiler warnings. For English phrases, either drop the quotes
or use escaped quotes where literal code is shown.
- Replace deprecated `point-at-eol'/`point-at-bol' with `line-end-position'/`line-beginning-position' - Replace deprecated `xref-pop-marker-stack' with `xref-go-back', guarded by fboundp for Emacs 28 compatibility - Replace `with-demoted-errors' with `condition-case-unless-debug' to avoid dynamic format string - Fix `put-text-property' on constant string literal - Fix defcustom :type specs (bare nil, 'list, double-quoted choice) - Add compat as a dependency and use `compat-call' for `plist-get'/`plist-put' with `equal' comparator, replacing the hand-rolled version-gating for deprecated `lax-plist-get'/`lax-plist-put' - Fix remaining docstring quoting flagged by the byte-compiler
Capture the return value of cl-delete-duplicates back into the items variable, since the function may return a new list head.
bbatsov
force-pushed
the
fix-pre-existing-warnings
branch
from
00903bd to
7d6ab9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
point-at-eol/point-at-bol,lax-plist-get/lax-plist-put,xref-pop-marker-stackdefcustom:typespecs ('list->'(repeat ...),''(choice ...)->'(choice ...), barenil->(const nil))with-demoted-errorswith dynamic format string withcondition-case-unless-debugput-text-propertyon constant string in cider-stacktrace.elcl-delete-duplicatesin cider-repl-history.elThese changes bring the project to zero byte-compilation errors/warnings.
Test plan
eldev -dtT compile --warnings-as-errorspasses with zero errors/warningseldev -p testpasses (426 specs, 0 failures)