[pre-commit.ci] pre-commit autoupdate - #385
Conversation
Changed Files
|
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates pinned versions of three pre-commit hooks (ruff, mypy, and complexipy) in .pre-commit-config.yaml to their latest patch / minor releases, with no other behavioral or configuration changes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
PR Summary
|
Up to standards βπ’ Issues
|
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #385 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 2674 2674
Branches 91 91
=========================================
Hits 2674 2674 β View full report in Codecov by Harness. π New features to boost your workflow:
|
|
Failed to generate code suggestions for PR |
There was a problem hiding this comment.
LlamaPReview β Blocking issues found
Ruff v0.16.3 activation of CPY001 makes the required static-tests check fail with 28 missing-copyright errors; do not merge until the pytest test files or Ruff config are updated.
Exact-head CI remains unresolved (3 failed); no CI-dependent merge-safety claim is made.
- Ruff v0.16.3 fails static-tests with 28 new CPY001 missing-copyright errors.
Owner action: Update the pre-commit hook config and test files or Ruff ignores so CPY001 no longer fails, then re-run static-tests.
Risk path
This focused view shows the single PR delta that verifies the blocking failure: the Ruff revision bump to v0.16.3 activates the CPY001 rule, causing the static-test check to fail at the PR head.
sequenceDiagram
participant PRC as PR Changes
participant RUFF as Ruff v0.16.3
participant CI as CI static-tests
participant OUT as Outcome
PRC->>RUFF: Activate ruff-check with selection ALL
note over RUFF: PR change - rev v0.16.3 activates CPY001
RUFF->>CI: Report 28 CPY001 errors (tests/*)
critical Blocking failure
CI->>OUT: Exit code 1 - check red
end
OUT-->>PRC: Merge blocked - fix or revert
Review details and evidence
| Priority | File | Finding | Evidence |
|---|---|---|---|
| P1 | .pre-commit-config.yaml |
Ruff v0.16.3 fails static-tests with 28 new CPY001 missing-copyright errors. | confirmed |
Material unknowns
- Whether Ruff v0.16.2 already enforced CPY001 and thus whether this failure is newly introduced or pre-existing. If v0.16.2 already enforced it, the failure is pre-existing debt rather than a new defect, but the head is still unmergeable and the owner action is unchanged.
- Check: Check an existing base-branch CI log for
static-testsunder v0.16.2 to see if CPY001 failures already occurred.
- Check: Check an existing base-branch CI log for
- Whether the complexipy hook's major bump (v6.2.0 to v7.0.1) changes default behavior, output format, or exit status. A major-version hook can alter defaults or output format; the failure currently observed is only from Ruff, and no complexipy failure has been seen, so this is a nonblocking compatibility unknown.
- Check: Verify the complexipy hook runs cleanly with v7.0.1 on a test environment or review its release notes/changelog.
- Whether the mypy and complexipy hooks actually ran successfully in the failing run. Since Ruff failed with CPY001, later hooks may not have been reached, so the absence of their output is not evidence of a pass.
- Check: Re-run the static-tests job after fixing the Ruff failures to confirm the mypy and complexipy bumps are regression-free.
LlamaPReview checks
- Reviewed changed regions in
.pre-commit-config.yaml. - Read bounded PR-head context from
pyproject.toml.
LlamaPReview reviewed this pull request at its exact head commit. Inspect the source or share feedback.
| - repo: https://github.com/astral-sh/ruff-pre-commit | ||
| rev: 'v0.16.2' | ||
| rev: 'v0.16.3' | ||
| hooks: | ||
| - id: ruff-check | ||
| - id: ruff-format |
There was a problem hiding this comment.
P1 | Confidence: High
The only changed component that can produce the observed output is the Ruff hook, whose rev changed from v0.16.2 to v0.16.3. The changed region enables ruff-check at the new revision. The pyproject.toml config selects ALL, which makes any rule added or newly stabilized by v0.16.3 active without further configuration; the ignore list and per-file-ignores for tests/*.py do not contain CPY001. The exact-head static-tests (3.14) logs show CPY001 Missing copyright notice at top of file for each test file (tests/<file>:1:1), Found 28 errors., and Process completed with exit code 1. The two runs fail identically. This makes the required static-test gate red at PR head, so merging unchanged would break the default branch's required checks.
Evidence: changed region in .pre-commit-config.yaml; bounded PR-head context from pyproject.toml.
f1b3dac to
ed3ba51
Compare
updates: - [github.com/astral-sh/ruff-pre-commit: v0.16.2 β v0.16.5](astral-sh/ruff-pre-commit@v0.16.2...v0.16.5) - [github.com/pre-commit/mirrors-mypy: v2.3.0 β v2.3.1](pre-commit/mirrors-mypy@v2.3.0...v2.3.1) - [github.com/abravalheri/validate-pyproject: v0.25 β 0.26](abravalheri/validate-pyproject@v0.25...0.26) - [github.com/rohaquinlop/complexipy-pre-commit: v6.2.0 β v7.0.1](rohaquinlop/complexipy-pre-commit@v6.2.0...v7.0.1)
ed3ba51 to
23c83ff
Compare
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
No application code in the PR β skipped Code Health checks.
See analysis details in CodeScene
Quality Gate Profile: Customizable Safeguards
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
updates:
Summary by Sourcery
Refresh pre-commit hooks and reformat affected documentation examples and type definitions.
Enhancements: