Added compression, better emitter /w tests#4
Closed
Zwork101 wants to merge 4 commits intoclamor-py:gatewayfrom
Closed
Added compression, better emitter /w tests#4Zwork101 wants to merge 4 commits intoclamor-py:gatewayfrom
Zwork101 wants to merge 4 commits intoclamor-py:gatewayfrom
Conversation
Not-Nik
requested changes
Jul 23, 2019
Member
Not-Nik
left a comment
Not-Nik
left a comment
There was a problem hiding this comment.
Looks fine. Just some minor changes/additions required to merge.
Author
|
NO NOT MERGE: Still a bug with the gateway reconnect test that needs to be resolved. |
Member
|
Ok, thanks for your effort. Just hit me up on Discord when this is ready to merge |
vbe0201
reviewed
Jul 28, 2019
Zwork101
commented
Aug 2, 2019
Author
Zwork101
left a comment
Zwork101
left a comment
There was a problem hiding this comment.
In total, added and implemented an emitter. Fixed a test, one test is still failing, but that's unrelated to the emitter.
Not-Nik
approved these changes
Aug 2, 2019
vbe0201
added
component: gateway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Please try to complete the below as best as possible. Some of the fields
may not be necessary so feel free to add or edit as you see fit.
Checklist
Confirm you have completed the following actions prior to submitting this PR.
Title
Added compression as an option, created a fully documented, better emitter, and created tests for said emitter.
Description
Decompression was changed so that this time we create a decompression object, and use it repeatedly to decompress information. A new emitter was added that supports priority, a bit more efficient and is documented. Lastly created tests for the the created emitter.
Issue Resolution
Doesn't fix, just enhances
This Pull Request fixes #3
New or Changed Features