Open
Conversation
fix for eval too long with api (insecure) when ckan xloader status
ThrawnCA
requested changes
Jan 22, 2026
| job_params = eval(job.description.replace( | ||
| 'ckanext.xloader.jobs.xloader_data_into_datastore', '')) | ||
| job_metadata = job_params['metadata'] | ||
| # FIX DEFINITIVO: |
| 'ckanext.xloader.jobs.xloader_data_into_datastore', '')) | ||
| job_metadata = job_params['metadata'] | ||
| # FIX DEFINITIVO: | ||
| # Non usare job.description (non è un canale dati stabile e può essere troncato). |
Collaborator
There was a problem hiding this comment.
How does this affect backward compatibility?
| metadata = {} | ||
|
|
||
| try: | ||
| if getattr(job, 'args', None) and len(job.args) >= 1: |
Collaborator
There was a problem hiding this comment.
Doesn't the truthiness check already ensure it's not empty?
| if isinstance(payload, dict): | ||
| metadata = payload.get('metadata') or {} | ||
| elif getattr(job, 'kwargs', None) and isinstance(job.kwargs, dict): | ||
| payload = job.kwargs.get('data') or job.kwargs |
Collaborator
There was a problem hiding this comment.
Why would it be "either the 'data' field or the whole thing"?
| payload = job.kwargs.get('data') or job.kwargs | ||
| if isinstance(payload, dict): | ||
| metadata = payload.get('metadata') or {} | ||
| except Exception: |
Collaborator
There was a problem hiding this comment.
Can we use a narrower exception type? Surely retrieving keys has a limited range of types it can raise.
| except Exception: | ||
| metadata = {} | ||
|
|
||
| res_id = metadata.get('resource_id', 'N/A') |
Collaborator
There was a problem hiding this comment.
I'm dubious about using "N/A" as the default value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for eval too long with api (insecure) when ckan xloader status