Skip to content

Handle empty multiple_checkbox#388

Open
frafra wants to merge 1 commit intockan:masterfrom
COATnor:handle-empty-multiple_checkbox
Open

Handle empty multiple_checkbox#388
frafra wants to merge 1 commit intockan:masterfrom
COATnor:handle-empty-multiple_checkbox

Conversation

@frafra
Copy link
Copy Markdown

@frafra frafra commented Sep 24, 2023

Fix #387.

I am not even sure if the "required" check code if ever run, since the validator is not executed when the field is missing when handling package_patch:

if field.get('required') and not selected:
errors[key].append(_('Select at least one'))

Therefore, I guess this patch should also fix this issue as well, since the validator should always be triggered. I have not tested it, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty multiple_checkbox is not saved

1 participant