Make org_with_dept_id example match the builtin form#365
Open
mmeisel wants to merge 1 commit intockan:masterfrom
Open
Make org_with_dept_id example match the builtin form#365mmeisel wants to merge 1 commit intockan:masterfrom
mmeisel wants to merge 1 commit intockan:masterfrom
Conversation
Contributor
|
@mmeisel would you merge master so we can get the tests running on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using this example as a reference (as I believe is the intention) when trying to add a single field to organizations without changing anything else. But the actual fields used by ckan (at least in 2.9) are named "description" and "image_url" rather than "notes" and "url". Since these are used by ckan on the organizations page, it's important they remain unchanged. So I think it would be better if the example uses the correct names.
While I was at it, I also made sure everything was using the correct preset (when available), made sure the labels matched, and increased the scheming_version to match the rest of the documentation.