Feature/add custom element built in support#137
Feature/add custom element built in support#137goto-bus-stop merged 37 commits intochoojs:masterfrom
Conversation
|
@goto-bus-stop |
|
@goto-bus-stop |
| var optionsArg | ||
|
|
||
| // this iife is a must to avoid illegal invocation type errors, caused by transformed nanohtml tests | ||
| (function () { |
There was a problem hiding this comment.
If tape would have before/after or setup/teardown support it could be implemented cleaner, but so far it gets the job done
|
@goto-bus-stop |
|
I would guess @goto-bus-stop is the most qualified to review this. I do know if we extend nanohtml we may also need to extend/test yoyoify to support the new changes. |
|
maybe yo-yoify should be deprecated on npm, this module includes a browserify transform i had a quick glance earlier and the approach looks good. i can prob review this proper on the weekend |
|
Oh yeahhhh. I forgot about that. +1 to that |
|
@bcomnes |
| } else if (tag === COMMENT_TAG) { | ||
| return document.createComment(props.comment) | ||
| } else if (isCustomElement) { | ||
| el = document.createElement(tag, { is: isCustomElement }) |
There was a problem hiding this comment.
please see the second optional options parameter
https://developer.mozilla.org/en-US/docs/Web/API/Document/createElement#Syntax
| if (ns) { | ||
| el = document.createElementNS(ns, tag) | ||
| if (isCustomElement) { | ||
| el = document.createElementNS(ns, tag, { is: isCustomElement }) |
There was a problem hiding this comment.
please see third optional options parameter
https://developer.mozilla.org/en-US/docs/Web/API/Document/createElementNS#Syntax
|
Hi @goto-bus-stop |
goto-bus-stop
left a comment
goto-bus-stop
left a comment
There was a problem hiding this comment.
looks great. one test nit & then it's good to go!
|
Awesome:) I have a little question too:) |
|
@goto-bus-stop |
|
Oops, must've ran the wrong update script. It's up now!
…On 16 November 2018 14:27:22 CET, Andreas ***@***.***> wrote:
@goto-bus-stop >
Great. Thanks for merging and releasing `1.3.0` 🚀 >
Unfortunately the latest version at npm I can install is `1.2.6`, May I
ask if you published already?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#137 (comment)
--
Sent from mobile. Please excuse my brevity.
|
|
Awesome, thank you so much :) And it works great. I'm doing a big refactoring which extends built-in elements.
Btw. I read in your release notes that autonomous custom elements |
|
lol, you're right. i was thinking of #121 but that's actually not about |
3 participants
fixes #136