Open
Conversation
mkurc-ant
force-pushed
the
testarch-noffmux
branch
2 times, most recently
from
7bf1b2a to
ce7de7f
Compare
acomodi
reviewed
Dec 2, 2021
Contributor
acomodi
left a comment
acomodi
left a comment
There was a problem hiding this comment.
LGTM, with one minor comment
| @@ -0,0 +1,14 @@ | |||
| generate_testarch_device_db( | |||
Contributor
There was a problem hiding this comment.
As we may want to generate different test architectures to test different features, we may want to put all of them under a testarchs directory?
Collaborator
Author
There was a problem hiding this comment.
Alright. But this change requires chipsalliance/python-fpga-interchange#143
mkurc-ant
force-pushed
the
testarch-noffmux
branch
from
ce7de7f to
8eb5f48
Compare
acomodi
suggested changes
Dec 2, 2021
Contributor
acomodi
left a comment
acomodi
left a comment
There was a problem hiding this comment.
LGTM apart from a small fix
mkurc-ant
force-pushed
the
testarch-noffmux
branch
from
9703fdb to
cb1b7b9
Compare
Signed-off-by: Maciej Kurc <mkurc@antmicro.com>
Signed-off-by: Maciej Kurc <mkurc@antmicro.com>
Signed-off-by: Maciej Kurc <mkurc@antmicro.com>
Signed-off-by: Maciej Kurc <mkurc@antmicro.com>
Signed-off-by: Maciej Kurc <mkurc@antmicro.com>
Signed-off-by: Maciej Kurc <mkurc@antmicro.com>
Signed-off-by: Maciej Kurc <mkurc@antmicro.com>
Signed-off-by: Maciej Kurc <mkurc@antmicro.com>
mkurc-ant
force-pushed
the
testarch-noffmux
branch
from
cb1b7b9 to
b02f227
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new test architecture
testarch_nolutffwhich requires the use of LUT-thrus for FF inputs.