Add Lennard-Jones implementation and training of dispersion coefficients#60
Draft
JMorado wants to merge 9 commits intochemle:mainfrom
Draft
Add Lennard-Jones implementation and training of dispersion coefficients#60JMorado wants to merge 9 commits intochemle:mainfrom
JMorado wants to merge 9 commits intochemle:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the Lennard-Jones EMLE, enabling it to function as a fully coupled scheme in which both electrostatics and dispersion are handled by emle-engine. There are two LJ modes:
flexible: the LJ parameters for the ML region are determined on-the-fly and are geometry-dependentfixed: the LJ parameters for the ML region are fixed, and can either be provided by the user or determined from a given geometry (e.g., an optimised structure)The main change compared to how the code worked before is that the forward pass of
EMLEnow always returns the LJ energy as the last output, which will be zero if no LJ mode is specified (the default). Everything else remains the same, meaning that old scripts should still work, as all LJ settings are optional.I've also added training routines for the required parameters. The learned property is the dispersion coefficient (e.g., C6), so one value per reference AEV is added to the model and learned by direct fitting to the targets.
I'm still expecting some changes in the future as this is being tested, so I'll leave this as a draft for now. Compatibility with Sander still needs to be added.