feat: add Timezone and pause/silence scope to MaintenanceWindow - #170
Draft
shiini2 wants to merge 1 commit into
Draft
feat: add Timezone and pause/silence scope to MaintenanceWindow#170shiini2 wants to merge 1 commit into
shiini2 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Timezone,PauseAllChecks,SilenceAlertsTagsandSilenceAllAlertstoMaintenanceWindow— all four already exist on the public API and the CLI deploy schema, but had no representation here.Both booleans are
*boolon purpose. A plainboolwithomitemptyis write-once:falseis treated as empty and dropped from the payload, so users could enable the scope and never disable it. The test sets pausetrueand silencefalsespecifically so the explicitfalsehas to survive the round-trip.Timezoneis a plain string — the backend accepts"UTC"as an explicit reset, matching the existingRepeatEndsAttreatment.Unblocks the matching terraform-provider-checkly change, which is held in draft until this is released.