Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected Components
Style
go fmtNotes for the Reviewer
This PR adds the required types for Groups V2 support.
Notably, a slightly breaking change is introduced: the SDK now changes the NO_RETRIES retry strategy, which was previously just
nil, toRetryStrategy { Type: "NO_RETRIES" }. This is marshaled tonilwhen marshaling JSON, andnilis unmarshaled intoRetryStrategy { Type: "NO_RETRIES" }as well. However, given that this poor man's SDK is only used by our Terraform provider, it should not be a huge deal.New Dependency Submission