feat: add Description field to StatusPage struct [SP-124]#152
Draft
feat: add Description field to StatusPage struct [SP-124]#152
Conversation
Member
|
Do you also intend to add this to TF or what's the deal here? |
Contributor
Author
@sorccu Yes exactly |
sorccu
reviewed
Mar 18, 2026
| Name string `json:"name"` | ||
|
|
||
| // Description is an optional introductory description. Maximum 500 characters. | ||
| Description string `json:"description,omitempty"` |
Member
There was a problem hiding this comment.
Is it safe to leave omitempty out? It's questionable whether the description can be removed or not (it will only be removable if the backend validation schema defines a default value).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Descriptionfield toStatusPagestruct (max 500 chars, omitempty)resolves SP-124
Test plan