Skip to content

feat: add Description field to StatusPage struct [SP-124]#152

Draft
shiini2 wants to merge 1 commit intomainfrom
manel/sp-123-add-description-to-status-page
Draft

feat: add Description field to StatusPage struct [SP-124]#152
shiini2 wants to merge 1 commit intomainfrom
manel/sp-123-add-description-to-status-page

Conversation

@shiini2
Copy link
Copy Markdown
Contributor

@shiini2 shiini2 commented Mar 18, 2026

Summary

  • Add optional Description field to StatusPage struct (max 500 chars, omitempty)

resolves SP-124

Test plan

  • Verify status page creation with description via SDK
  • Verify description is returned when fetching status pages

@shiini2 shiini2 requested a review from a team as a code owner March 18, 2026 08:23
@sorccu
Copy link
Copy Markdown
Member

sorccu commented Mar 18, 2026

Do you also intend to add this to TF or what's the deal here?

@shiini2
Copy link
Copy Markdown
Contributor Author

shiini2 commented Mar 18, 2026

Do you also intend to add this to TF or what's the deal here?

@sorccu Yes exactly

Name string `json:"name"`

// Description is an optional introductory description. Maximum 500 characters.
Description string `json:"description,omitempty"`
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to leave omitempty out? It's questionable whether the description can be removed or not (it will only be removable if the backend validation schema defines a default value).

@shiini2 shiini2 changed the title feat: add Description field to StatusPage struct [SP-123] feat: add Description field to StatusPage struct [SP-124] Mar 19, 2026
@shiini2 shiini2 marked this pull request as draft March 19, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants