fix: empty gif after ffmpeg error "Number of frames to loop is not set"#695
Open
majiayu000 wants to merge 1 commit intocharmbracelet:mainfrom
Open
Conversation
The FFmpeg loop filter requires the size parameter to specify the number of frames to loop. Without this parameter, FFmpeg emits the warning "Number of frames to loop is not set!" and may produce empty or invalid GIF output, especially with long recordings. This fixes the loop filter in WithWindowBar and WithBorderRadius methods by changing `loop=-1` to `loop=-1:1:0` (infinite loop, 1 frame, start at 0). Fixes charmbracelet#581 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: majiayu000 <[email protected]>
majiayu000
requested review from
kujtimiihoxha and
tauraamui
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #581
Changes
:1:0) to ffmpeg loop filter for window bar and border radius masksizeparameter when using infinite loopThe loop filter syntax is
loop=loop_count:size:start. The bar and mask are single-frame PNG images, sosize=1withstart=0is correct.🤖 Generated with Claude Code