Open
Conversation
Member
|
Nice! Could you add a test about the implementation? 🙏 |
Author
|
I added a test for this. Let me know if its enough, or I need to add more. |
caarlos0
approved these changes
Apr 22, 2025
Member
caarlos0
left a comment
caarlos0
left a comment
There was a problem hiding this comment.
minor comments, looks good otherwise
parser/parser.go
Outdated
Comment on lines
160
to
161
| // return []Command{p.parseCtrl()} | ||
| return p.parseCtrl() |
Member
There was a problem hiding this comment.
Suggested change
| // return []Command{p.parseCtrl()} | |
| return p.parseCtrl() | |
| return p.parseCtrl() |
parser/parser.go
Outdated
| return Command{Type: token.CTRL, Args: ctrlArgs} | ||
| repeat, _ := strconv.Atoi(p.parseRepeat()) | ||
|
|
||
| var cmds []Command |
Member
There was a problem hiding this comment.
Suggested change
| var cmds []Command | |
| cmds := make([]Command, 0, repeat) |
Author
|
Updated accordingly. |
raphamorim
approved these changes
Apr 22, 2025
Member
|
Nice! thank you |
|
Is anything stopping this from being merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solve issue #340