Expand python format CI check to all code but third-party#28437
Merged
arifthpe merged 11 commits intochapel-lang:mainfrom Mar 2, 2026
Merged
Expand python format CI check to all code but third-party#28437arifthpe merged 11 commits intochapel-lang:mainfrom
arifthpe merged 11 commits intochapel-lang:mainfrom
Conversation
67da980 to
84fc2bf
Compare
4e1ae99 to
226c3aa
Compare
2d2aa9e to
8771cb1
Compare
DanilaFe
approved these changes
Feb 24, 2026
Signed-off-by: Anna Rift <anna.rift@hpe.com>
To keep default excluded patterns Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
8771cb1 to
1178e61
Compare
1 task
arifthpe
added a commit
that referenced
this pull request
Mar 4, 2026
Switch from expecting single quotes to expecting double quotes in version strings searched for by `util/config/update-release-and-version-info`. This is a consequence of the formatting pass run in #28437. This only affected Python files, and the only Python file the version script touches is `doc/rst/conf.py`, so that is the only one needing adjustment to its handling. I caught this when manually checking #28494. [trivial, not reviewed] Testing: - [x] after fix, version update script generates the expected results (#28494)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand python formatting check CI workflow (which uses
black) to the entire repo exceptthird-party/andtest/, andblacken all affected files once to begin with.Also:
2to3on files thatblackfailed to process (as a one-off), which was due to them being written for Python 2.blackCI check to use latest available (currently26.1.0, previously pinned to24.4.0).pushworkflow trigger so this runs on pushes tomain.[reviewer info placeholder]
Testing: