Skip to content

Expand python format CI check to all code but third-party#28437

Merged
arifthpe merged 11 commits intochapel-lang:mainfrom
arifthpe:expand-python-format-check
Mar 2, 2026
Merged

Expand python format CI check to all code but third-party#28437
arifthpe merged 11 commits intochapel-lang:mainfrom
arifthpe:expand-python-format-check

Conversation

@arifthpe
Copy link
Collaborator

@arifthpe arifthpe commented Feb 23, 2026

Expand python formatting check CI workflow (which uses black) to the entire repo except third-party/ and test/, and blacken all affected files once to begin with.

Also:

  • Manually run 2to3 on files that black failed to process (as a one-off), which was due to them being written for Python 2.
  • Set black CI check to use latest available (currently 26.1.0, previously pinned to 24.4.0).
  • Add push workflow trigger so this runs on pushes to main.

[reviewer info placeholder]

Testing:

  • CI check passes
  • CI check fails on incorrectly formatted python files
  • paratest

@arifthpe arifthpe force-pushed the expand-python-format-check branch 2 times, most recently from 67da980 to 84fc2bf Compare February 23, 2026 18:59
@arifthpe arifthpe requested a review from DanilaFe February 23, 2026 19:04
@arifthpe arifthpe force-pushed the expand-python-format-check branch 3 times, most recently from 4e1ae99 to 226c3aa Compare February 23, 2026 19:06
@arifthpe arifthpe marked this pull request as ready for review February 23, 2026 19:08
@arifthpe arifthpe force-pushed the expand-python-format-check branch 5 times, most recently from 2d2aa9e to 8771cb1 Compare February 24, 2026 19:56
arifthpe added 11 commits March 2, 2026 09:53
Signed-off-by: Anna Rift <anna.rift@hpe.com>
To keep default excluded patterns

Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
@arifthpe arifthpe force-pushed the expand-python-format-check branch from 8771cb1 to 1178e61 Compare March 2, 2026 17:53
@arifthpe arifthpe merged commit 540d168 into chapel-lang:main Mar 2, 2026
10 checks passed
@arifthpe arifthpe deleted the expand-python-format-check branch March 2, 2026 17:54
arifthpe added a commit that referenced this pull request Mar 4, 2026
Switch from expecting single quotes to expecting double quotes in
version strings searched for by
`util/config/update-release-and-version-info`.

This is a consequence of the formatting pass run in
#28437. This only affected
Python files, and the only Python file the version script touches is
`doc/rst/conf.py`, so that is the only one needing adjustment to its
handling. I caught this when manually checking
#28494.

[trivial, not reviewed]

Testing:
- [x] after fix, version update script generates the expected results
(#28494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants