chore: remove tox configuration and dependencies (#3526) #3529
Conversation
guptapratykshh
force-pushed
the
fix/remove-tox
branch
from
d5cb535 to
f3d58b1
Compare
|
|
||
| ``make test-python-versions`` | ||
| ----------------------------- | ||
| The above command runs all tests under all currently supported versions of **Python 3.6 and above**. | ||
|
|
||
| Example\: | ||
|
|
||
| .. code-block:: bash | ||
|
|
||
| $ make test-python-versions |
There was a problem hiding this comment.
Can we replace this with the command to run pytest?
scripts/control/clean.sh
Outdated
| find . -wholename build -delete | ||
| find . -wholename dist -delete | ||
| rm -rf .tox/ | ||
|
|
There was a problem hiding this comment.
we may want to keep this around for a bit with a comment explaining how it cleans up stuff that no longer exists.
if people heavily use the makefile and update, running clean after update wont remove any leftover .tox folders if they didnt clean before the update
|
|
||
| .. _GitHub: https://github.com/chaoss/augur/issues | ||
|
|
||
| These commands are used to run specific subsets of unit tests. We use ``tox`` to manage the test environments, and ``pytest`` as the test runner. Each of these commands except for ``make test-pythons-versions`` will use your default Python version, while ``make test-python-versions`` will test all supported Python versions. |
There was a problem hiding this comment.
good catch! i forgot to update the docs in my version of this
MoralCode
added
the
waiting
|
Something to note is that, even though its an "issue" in the github sense, the issue behind this wasnt really intended to be fixed just yet as im still waiting to give the maintainers a chance to object. That said, this is still helpful, but im going to mark it as waiting for now |
guptapratykshh
force-pushed
the
fix/remove-tox
branch
2 times, most recently
from
74cc91d to
d48572e
Compare
Signed-off-by: Pratyksh Gupta <[email protected]>
guptapratykshh
force-pushed
the
fix/remove-tox
branch
from
d48572e to
f80d283
Compare
|
Thanks for the update. I understand this is waiting for a final decision. I have made the requested updates by replacing the outdated make target documentation with direct |
|
Will review/merge this in 72 hours if my followup on a decision remains unanswered. Could you rebase this in the meantime? |
2 participants
Description
This PR removes tox from the project's development and testing workflow. As mentioned in the issue, tox's ability to test multiple Python versions conflicts with the current GitHub Actions setup. It is also no longer actively used for local development.
This PR fixes #3526
Notes for Reviewers
The testing workflow is now fully standardized on pytest. Developers should use make test or uv run pytest.
Signed commits