fix(date-picker): match keyboard range selection to pointer behavior#3205
Open
olaf-k wants to merge 2 commits into
Open
fix(date-picker): match keyboard range selection to pointer behavior#3205olaf-k wants to merge 2 commits into
olaf-k wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: d0baf58 The changes in this PR will be included in the next version bump. This PR includes changesets to release 86 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR fixes the datepicker's keyboard range selection to match the pointer behavior. It also includes code to resume an incomplete range when reopening the calendar.
⛳️ Current behavior (updates)
When the datepicker is set with
selectionMode: "range":(All these scenarios can be reproduced locally or on the Chakra example page.)
🚀 New behavior
resetSelectionis used in keyboard navigation as it is with mouse navigation.focusNextDayis used when we're in this scenario.setHoveredValueIfKeyboardtakes navigation using non-arrow keys into account.resumeRangeSelectionadded to cater to this particular scenario.💣 Is this a breaking change (Yes/No):
No.
📝 Additional Information
The fourth point is a UX judgment call. As such, it has been isolated in a separate commit should you want to drop it and keep the current behavior.