fix(drawer): prevent backdrop flickering when using an async open setter#3197
Open
adjsky wants to merge 1 commit into
Open
fix(drawer): prevent backdrop flickering when using an async open setter#3197adjsky wants to merge 1 commit into
adjsky wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 8121ec9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 86 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the backdrop part in #3149.
⛳️ Current behavior (updates)
Currently,
deferClearDragOffsetaddsanimation: none !importantto the backdrop node,clearSwipeOpenAnimationis intended to clear this style, but due to a timing issue, it runs before theCONTROLLED.CLOSEevent is received, and since the drawer is not yet in closing state, the opening animation runs.🚀 New behavior
Now, if there is a defined
onOpenChangeprop,clearSwipeOpenAnimationonly runs when theCONTROLLED.CLOSEevent is received.💣 Is this a breaking change (Yes/No):
No.
📝 Additional Information