Conversation
Signed-off-by: s-stumbo <[email protected]>
✅ Deploy Preview for ornate-narwhal-088216 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
matthewhelmke
approved these changes
Mar 20, 2026
Collaborator
matthewhelmke
left a comment
matthewhelmke
left a comment
There was a problem hiding this comment.
I've used Maven and this looks solid. I did not test the code.
mosabua
requested changes
Mar 20, 2026
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
We should not merge this as it stands as it is promoting bad practices
Signed-off-by: s-stumbo <[email protected]>
Signed-off-by: s-stumbo <[email protected]>
Signed-off-by: s-stumbo <[email protected]>
mosabua
requested changes
Mar 23, 2026
| Then build the project: | ||
|
|
||
| ```bash | ||
| mvn compile |
Member
There was a problem hiding this comment.
either
mvn package
or better even
mvn install
| Use the following steps to create a minimal example project for Maven with Chainguard Libraries for Java. | ||
|
|
||
| ```bash | ||
| mkdir maven-example |
|
|
||
| ```bash | ||
| mkdir maven-example | ||
| cd maven-example |
| mvn install | ||
| ``` | ||
|
|
||
| Following this, find the downloaded package in `~/.m2/repository/com/google/guava/guava/`. |
Member
There was a problem hiding this comment.
Thats not correct .. what package is actually downloaded and why? You should check in the pom and then details the exact file name and then also verify with chainctl
Signed-off-by: s-stumbo <[email protected]>
Signed-off-by: s-stumbo <[email protected]>
Signed-off-by: s-stumbo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] Check if this is a typo or other quick fix and ignore the rest :)
Type of change
Update existing Java Build Configuration docs
What should this PR do?
Add minimal example project for Maven
Why are we making this change?
Internal feedback - see related issue here
What are the acceptance criteria?
How should this PR be tested?
Follow the steps to test the Maven example project