Conversation
Signed-off-by: s-stumbo <sally.stumbo@chainguard.dev>
✅ Deploy Preview for ornate-narwhal-088216 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: s-stumbo <sally.stumbo@chainguard.dev>
Signed-off-by: s-stumbo <sally.stumbo@chainguard.dev>
matthewhelmke
left a comment
matthewhelmke
left a comment
There was a problem hiding this comment.
I did not test the new code, but it passes a sanity check. It should work. If you trust the source and/or have tested it yourself, I think this LGTM.
| sections](#minimal-example-project) on this page for per-tool authentication | ||
| setup. | ||
|
|
||
| The fastest way to get credentials and configure your project in one step is |
There was a problem hiding this comment.
Why duplicate this here and not just refer to the minimal example?
|
|
||
| The fastest way to get credentials and configure your project in one step is | ||
| with chainctl: | ||
| ```bash |
There was a problem hiding this comment.
Also keep in mind that this all is for direct access only .. which we still consider not as good as using a repo manager .. so it should not be as prominent
|
|
||
| ```shell | ||
| ```bash | ||
| eval $(chainctl auth pull-token --output env --repository=javascript --parent=<your-org>) |
There was a problem hiding this comment.
I would not add that here. If you really think it should be in this section then I would add it as separate snippet earlier and maybe talk about adding it in the .env file or so and sourcing that. When I wrote this I relied on the fact that the linked section explains that .. maybe that should be improved instead of duplicating it here
| Pointing your existing build tools or repository manager tools at the Chainguard Repository gives you: | ||
| * Access to both Chainguard-built packages and upstream npm packages (when fallback is enabled), so you don't need to maintain a parallel npm fallback configuration. | ||
| * Malware scanning and a cooldown period applied to all packages the repository serves, including those proxied from npm. | ||
| Chainguard Repository is a unified Chainguard-managed experience for pulling |
There was a problem hiding this comment.
I think this whole page should be deleted and the relevant info should be moved in the Chainguard Libraries for JavaScript section and maybe the page about console browsing
There was a problem hiding this comment.
Thanks, I'll address this in a separate PR
Signed-off-by: s-stumbo <sally.stumbo@chainguard.dev>
Signed-off-by: s-stumbo <sally.stumbo@chainguard.dev>
s-stumbo
changed the title
3 participants
[ ] Check if this is a typo or other quick fix and ignore the rest :)
Type of change
Clarify existing content around direct access for JS
What should this PR do?
Why are we making this change?
What are the acceptance criteria?
How should this PR be tested?
Follow the docs to test out setting up Chainguard repo for JS