[Snyk] Security upgrade golang from 1.12 to 1.26rc2#127
[Snyk] Security upgrade golang from 1.12 to 1.26rc2#127stevemac007 wants to merge 1 commit intomasterfrom
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-DEBIAN10-NGHTTP2-5953390 - https://snyk.io/vuln/SNYK-DEBIAN10-GIT-6846202 - https://snyk.io/vuln/SNYK-DEBIAN10-GIT-6846202 - https://snyk.io/vuln/SNYK-DEBIAN10-OPENSSH-5788320 - https://snyk.io/vuln/SNYK-DEBIAN10-SYSTEMD-3339153
There was a problem hiding this comment.
Security Upgrade Review
This PR addresses critical security vulnerabilities by upgrading the Go base image from 1.12 to 1.26rc2. While the security improvements are important, there's a significant concern with using a release candidate version in production.
Key Issues:
- Production Risk: The upgrade uses Go 1.26rc2 (release candidate) which may introduce stability issues
Recommendation:
Consider using the latest stable Go version (1.25) instead of the release candidate to maintain production stability while still addressing the security vulnerabilities. The security benefits can be achieved with a stable release that provides better reliability guarantees.
The security vulnerabilities being addressed are critical (CVE-2023-44487, Git Link Following, SSH vulnerabilities), so this upgrade should proceed, but with a stable version.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
| @@ -1,5 +1,5 @@ | |||
| # start from an upstream, maintained build image for Go | |||
| FROM golang:1.12 | |||
| FROM golang:1.26rc2 | |||
There was a problem hiding this comment.
🛑 Production Risk: Using a release candidate version (1.26rc2) in production environments is risky. Release candidates are pre-release versions that may contain bugs or instability issues that could affect application reliability.
| FROM golang:1.26rc2 | |
| FROM golang:1.25 |
Snyk has created this PR to fix 4 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):
02-build-and-test/DockerfileWe recommend upgrading to
golang:1.26rc2, as this image has only 133 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.Vulnerabilities that will be fixed with an upgrade:
SNYK-DEBIAN10-NGHTTP2-5953390
SNYK-DEBIAN10-GIT-6846202
SNYK-DEBIAN10-GIT-6846202
SNYK-DEBIAN10-OPENSSH-5788320
SNYK-DEBIAN10-SYSTEMD-3339153
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.