Skip to content

nvmeof: rearrange controllerserver#6178

Merged
mergify[bot] merged 1 commit intoceph:develfrom
gadididi:nvmeof/fix_issue_6098
Mar 18, 2026
Merged

nvmeof: rearrange controllerserver#6178
mergify[bot] merged 1 commit intoceph:develfrom
gadididi:nvmeof/fix_issue_6098

Conversation

@gadididi
Copy link
Contributor

@gadididi gadididi commented Mar 12, 2026 •
edited
Loading

move setupDefaultListenersValues from controllerserver.go to the right place - volume.go
Also added unit test for it.

fix issue :
#6098

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer
    guide    .
  • Reviewed the developer guide on Submitting a Pull
    Request
  • Pending release
    notes
    updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@gadididi gadididi requested a review from nixpanic March 12, 2026 13:46
@gadididi gadididi self-assigned this Mar 12, 2026
@gadididi gadididi added the component/nvme-of Issues and PRs related to NVMe-oF. label Mar 12, 2026
nixpanic
nixpanic reviewed Mar 12, 2026
View reviewed changes
Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new SetListenersWithDefaults() function is an ideal candidate for a unit test 😃

@gadididi gadididi force-pushed the nvmeof/fix_issue_6098 branch 2 times, most recently from bae1a67 to 85577a3 Compare March 15, 2026 12:14
@gadididi gadididi requested review from a team and nixpanic March 15, 2026 12:14
@gadididi
Copy link
Contributor Author

gadididi commented Mar 17, 2026

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2026 •
edited
Loading

Merge Queue Status

🛑 Queue command has been cancelled

@gadididi
Copy link
Contributor Author

gadididi commented Mar 17, 2026

@Mergifyio rebase

@gadididi gadididi added the ok-to-test Label to trigger E2E tests label Mar 17, 2026
@ceph-csi-bot ceph-csi-bot force-pushed the nvmeof/fix_issue_6098 branch from 85577a3 to c453e81 Compare March 17, 2026 11:38
@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2026

rebase

✅ Branch has been successfully rebased

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/k8s-e2e-external-storage/1.34

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/k8s-e2e-external-storage/1.33

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/k8s-e2e-external-storage/1.35

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/mini-e2e-helm/k8s-1.33

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/mini-e2e-helm/k8s-1.34

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/mini-e2e-helm/k8s-1.35

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/mini-e2e/k8s-1.33

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/mini-e2e/k8s-1.34

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/mini-e2e/k8s-1.35

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Mar 17, 2026
@gadididi
Copy link
Contributor Author

gadididi commented Mar 17, 2026

/test ci/centos/mini-e2e-helm/k8s-1.33

@nixpanic
Copy link
Member

nixpanic commented Mar 17, 2026

@Mergifyio queue

@nixpanic
Copy link
Member

nixpanic commented Mar 17, 2026

@Mergifyio rebase

@nixpanic
Copy link
Member

nixpanic commented Mar 17, 2026

Somehow Mergify is stuck? After rebasing (again), the ok-to-test label can be added and the PR should get merged automatically after that.

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2026

queue

☑️ Command queue ignored because it is already running from a previous command.

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2026

rebase

☑️ Nothing to do, the required conditions are not met

Details
  • queue-position = -1 [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • -conflict [📌 rebase requirement]
  • any of:
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]

@mergify mergify bot added the queued label Mar 17, 2026
@gadididi @ceph-csi-bot
nvmeof: rearrange controllerserver
3e54dec 
move setupDefaultListenersValues from controllerserver.go
to the right place - volume.go

Signed-off-by: gadi-didi <[email protected]>
@ceph-csi-bot ceph-csi-bot force-pushed the nvmeof/fix_issue_6098 branch from c453e81 to 3e54dec Compare March 17, 2026 21:36
@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2026 •
edited
Loading

Merge Queue Status

  • ✅ Entered queue — 2026-03-17 21:36 UTC · Rule: default
  • ✅ Checks passed · in-place
  • ✅ Merged — 2026-03-18 00:29 UTC · at 3e54decb23cc74e261e5f8a39e59c7cb173c5835

This pull request spent 2 hours 52 minutes 55 seconds in the queue, including 2 hours 52 minutes 14 seconds running CI.

Required conditions to merge

@mergify mergify bot added ci/in-progress/e2e This label acts like a guard and prevents Mergify from adding the `ok-to-test` label again. ok-to-test Label to trigger E2E tests labels Mar 17, 2026
@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/k8s-e2e-external-storage/1.33

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/k8s-e2e-external-storage/1.34

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/k8s-e2e-external-storage/1.35

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/mini-e2e-helm/k8s-1.33

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/mini-e2e-helm/k8s-1.34

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/mini-e2e-helm/k8s-1.35

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/mini-e2e/k8s-1.33

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/mini-e2e/k8s-1.34

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/mini-e2e/k8s-1.35

@ceph-csi-bot
Copy link
Collaborator

ceph-csi-bot commented Mar 17, 2026

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Mar 17, 2026
@mergify mergify bot merged commit ca2c911 into ceph:devel Mar 18, 2026
40 checks passed
@mergify mergify bot removed the queued label Mar 18, 2026
@gadididi gadididi mentioned this pull request Mar 18, 2026
Closed
@gadididi gadididi deleted the nvmeof/fix_issue_6098 branch March 18, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nixpanic nixpanic nixpanic approved these changes

@black-dragon74 black-dragon74 black-dragon74 approved these changes

Assignees

@gadididi gadididi

Labels

ci/in-progress/e2e This label acts like a guard and prevents Mergify from adding the `ok-to-test` label again. component/nvme-of Issues and PRs related to NVMe-oF.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gadididi @ceph-csi-bot @nixpanic @black-dragon74