feat(apps::monitoring::zscaler::zdx::api): new plugin #5938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sylvain Cresto <[email protected]>
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
scresto31
reviewed
Jan 22, 2026
Comment on lines
+2
to
+4
| "dependencies": [ | ||
| "libjson-perl" | ||
| ] |
Comment on lines
+3
to
+4
| "perl(DateTime)", | ||
| "perl(JSON)" |
Comment on lines
+27
to
+28
| use DateTime; | ||
| use JSON::XS; |
| foreach my $met (@$metrics) { | ||
| $data->{$met->{metric}} = -1; # -1 means no value has been recorded | ||
| LOOP_VALUES: | ||
| while ( my $dp = pop(@{$met->{datapoints}}) ) { |
Contributor
There was a problem hiding this comment.
I find this more readable, but it's just my opinion
Suggested change
| while ( my $dp = pop(@{$met->{datapoints}}) ) { | |
| foreach my $dp (reverse @{$met->{datapoints}}) { |
|
|
||
| foreach (qw(key_id key_secret)) { | ||
| $self->{output}->option_exit(short_msg => "Mandatory option '$_' is missing.") if ($self->{$_} eq ''); | ||
| $self->{output}->option_exit(short_msg => "Option '$_' contains illegal characters '$1'") if ($self->{$_} =~ /([\b\f\n\r\t\"\\]+)/); |
Contributor
There was a problem hiding this comment.
The display of the illegal character will probably not work correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to use this plugin:
discoverymode to get the applications names and IDs--application-id=<ID>option to specify the application you want to monitorlist-locationsmode to get the locations names and IDs--location-id=<ID>option to narrow the field of data to a specific locationIf you have an IT license, just use the host discovery provider and then the service discovery rule to get set.
Refs: CTOR-1961
Type of change
Checklist