chore: sync upstream cella v0.10.2 (55af2fac) - #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs upstream cellajs/cella to
55af2fa(v0.10.2).7 upstream commits since last sync (compare):
45923f2fix(sync): act on app sync feedback: marker-aware vocabulary gate, route tree script, portable mention fixture (fix(sync): act on app sync feedback: marker-aware vocabulary gate, route tree script, portable mention fixture cella#1150)8870467fix(attachments): description edits survive stale clocks, emptied documents and sheet dismissal; keywords derived on update (fix(attachments): description edits survive stale clocks, emptied documents and sheet dismissal; keywords derived on update cella#1152)4e83dfefeat: attachment and yjs refactoring (feat(seed): attachment rows point at published seed assets in the public bucket cella#1146)a826b1ffix(attachment): dialog image fits between the chrome, one zoom clamp for wheel, pinch and buttons (fix(attachment): dialog image fits between the chrome, one zoom clamp for wheel, pinch and buttons cella#1153)17d7838chore: update dependencies (chore: update dependencies cella#1154)b682f78fix(test): exclude the storybook browser project from root vitest runs (fix(test): exclude the storybook browser project from root vitest runs cella#1155)55af2fachore(main): release 0.10.2 (chore(main): release 0.10.2 cella#1151)Conflicts
One:
backend/tests/attachment-notifications.test.ts. Upstream #1150 adopted raak's most-privileged-role fixture, so ours = theirs + fork marker. Took theirs, marker retired. No fork markers remain in cella-owned code except the new bench seed below.Migrations marked (3)
20260907T0619-route-tree-generation-script:gen:routes/generate:routesscripts and@tanstack/router-generatorarrived through package sync;vite.config.tsnow usesvite/router-options.ts. Verified:pnpm generate:routesleavesrouteTree.gen.tsunchanged.20260907T0711-description-seed-preview-hooks:15-tasks.seed.tsbuilds paragraphs withparagraphBlock/textfromdescription-document.ts(checklist loop kept, explicit props in BlockNote key order);use-task-description-update.tscomposespatchCollaborativeDescription+persistStandaloneDescription(derived props computed once,triggerTaskGlowkept after the collaborative patch). The task editor already renders a faded static preview aswaitingFallback.20-attachment.seed.tsstill goes through the pinned placement seam.20260909T0740-yjs-update-log:pnpm generateemitted20260909171506_calm_scarlet_witch(yjs_updatestable, RLS enabled,last_edited_bydropped) +20260909171507_side_effects(RLS set now 5 tables). No fork code imports the yjs storage API.y-websocketdev dep installed.Pinned files
Upstream touched two pinned files with comment/copy-only deltas:
routes-config.tsx(notificationSearchdoc comment, hand-adopted) andlocales/en/about.json(sync_diagram.part_3.text, key not present in raak's about.json, nothing to adopt).Tests
pnpm checkclean.pnpm test(full, docker test db): 2721 passed, two failures triaged:bench/src/tests/all-scenarios.test.ts: pre-existing since 2026-09-02, not sync damage (fails identically onmain). Two causes, both fixed here: raak'sattachments.project_idFK (Feat/cella drift convergence #131) while the bench attachment seed never assigned a project, andtasks.mentions(v0.9.8 sync) not declared as a native pg array. Fix: fork-markedprojectId+order: 115inbench/src/seeds/attachment.bench.ts,'mentions'added topgArrayColumnsin fork-ownedtask.bench.ts. Passes now.yjs/src/tests/integration/concurrency.test.ts"burst of keystrokes" e2e: upstream flake, ~1 in 5 runs on an idle machine,readLog(...).length === 3never met within 3 s. raak'syjs/is byte-identical to upstream. Likely the relay's server-side Step1 pull racing the burst (a 4th log row, or compaction consuming the log before the poll sees 3). To report upstream.Drift (
pnpm cella analyze)before: diverged 1, pinned 2, drifted 0, behind 107 → after: diverged 0, pinned 0, drifted 1, behind 5.
bench/src/seeds/attachment.bench.ts, fork-marked (project-homed attachment axis). Candidate extension point: a bench placement hook next to the backendattachment-placement.tsseam would let the fork drop the marker.