chore(deps): bump celestia-app to v9 arabica release#4999
Open
rach-id wants to merge 2 commits into
Open
Conversation
Contributor
vgonkivs
reviewed
May 21, 2026
| // Used for syncer tail height estimation to ensure the tail stays within the pruning | ||
| // window despite block time variance (real block times on mocha avg ~6.14s vs nominal 6s). | ||
| const maxBlockTime = 7 * time.Second | ||
| const maxBlockTime = 4 * time.Second |
Member
There was a problem hiding this comment.
do we know what will be the real block time in this case? Also, please updated the comment with ~6.14s
Member
Author
There was a problem hiding this comment.
the real block time will be ~2.7s. I found it set to 7s where the current one is 6s, so I thought we add one second to be on the safe side
Member
There was a problem hiding this comment.
Previously, BN was receiving the block with ~6.14s delay, so we decided to make it bigger on our end.
Member
Author
There was a problem hiding this comment.
so is 4s a good number or I bring it down to 3s?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps celestia-app to v9