-
-
Notifications
You must be signed in to change notification settings - Fork 981
Update uuid to uuid7 #2303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update uuid to uuid7 #2303
Conversation
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2303 +/- ##
==========================================
- Coverage 81.19% 81.17% -0.03%
==========================================
Files 77 77
Lines 9738 9747 +9
Branches 1098 1100 +2
==========================================
+ Hits 7907 7912 +5
- Misses 1625 1628 +3
- Partials 206 207 +1 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the UUID generation utility to support UUID version 7 while retaining support for UUID4 as a fallback option. Key changes include switching the function parameter from a Callable to a version literal and introducing a try/except block for importing uuid7 with a fallback implementation.
Co-authored-by: Copilot <[email protected]>
|
this will need tests update and thorough testing before merge |
|
My $0.02: it should still be possible to manually specify UUID4s - to not break the case where pre-generated UUID4s are passed to signatures. |
would you mind elaborate a bit more please? so that I can clearly understand what you wanted to be done here? |
Sure: This use case should not break: |
|
OK, thanks a lot! |
Co-authored-by: Gert Van Gool <[email protected]>
|
Found 1 test failure on Blacksmith runners: Failure
|
No description provided.