refactor!: remove manual registration of Gitlab Runner#388
Draft
kayman-mk wants to merge 41 commits intocattle-ops:mainfrom
Draft
refactor!: remove manual registration of Gitlab Runner#388kayman-mk wants to merge 41 commits intocattle-ops:mainfrom
kayman-mk wants to merge 41 commits intocattle-ops:mainfrom
Conversation
Collaborator
|
@kayman-mk need a bit more time for this PR. I am happy to drop this really old feature. |
joshbeard
reviewed
Oct 21, 2021
Collaborator
|
On my list! |
Collaborator
|
@kayman-mk can you rebase this PR, will check this early next week. So I can release all breaking changes at once. |
…/terraform-aws-gitlab-runner into kayma/register-runner-manually
Collaborator
|
thx |
99195e5 to
9767603
Compare
npalm
reviewed
Aug 15, 2022
Collaborator
npalm
left a comment
There was a problem hiding this comment.
Tested and looks good to me, one small remark.
Collaborator
Author
|
@npalm Everything fixed. |
Collaborator
Author
|
@npalm What about this PR? |
Collaborator
Goinng to dig in. |
Contributor
|
@kayman-mk, maybe we could also suggest users to use the GitLab Terraform Provider to obtain their registration token?
Way I'm using the module right now: This would not work however for instance runners since there is no API. Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/16319 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Removes the ability to register a Gitlab Runner manually (as described in #186) and pass the token into the module. This was done using
secure_parameter_store_runner_token_keyIt's now recommended to let the Gitlab Runner fetch the registration token from Gitlab and store it into a SSM parameter automatically.
If you use the
secure_parameter_store_runner_token_keyin the past: This SSM parameter is destroyed for every runner agent and a new one is created which is managed by the module. This means that new runners will register with Gitlab again.Another way to get the token is the
gitlabhq/gitlabprovider. Check the data sourcesgitlab_groupandgitlab_project. It does not work for instance runners as there is no data source available.Closes #186
Migrations required
Verification
Deployed the new version of the module into our production environment and ran some build jobs. Worked fine.
ToDo