fix: updating function aggregate to return int too#1062
Open
manofstrong wants to merge 1 commit intocatfan:masterfrom
Open
fix: updating function aggregate to return int too#1062manofstrong wants to merge 1 commit intocatfan:masterfrom
manofstrong wants to merge 1 commit intocatfan:masterfrom
Conversation
private function aggregate returning only string or null in strict mode is causing public function count to return a fatal error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running function count at the moment returns this fatal error:
This is caused by private function aggregate requiring a string return:
while public function count returns (and requires the return of ) an int type
my solution here is adding int return to private function aggregate