Open
Conversation
0e9a58f to
e122664
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Some of this might not be conflicting with the new dataset branch (im def not passive aggressively finishing this PR now :^)
Features:
--fill_missing_stampswhich gives optional behavior to pull timestamp from bag if no timestamp in topic (such as steering_angle)optionalarg to topics which are not always present e.g. racepak, RTK topics.Multiprocessing
Taking advantage of each topic's independence from one another, I distribute each topic to an independent process to process the data into KITTI format. Future work should also try to add multiple processes for a single, more computationally demanding topic like perception data and split up the frames to process.
I kept the
ros2bag_2_kitti.pyalone, and made a newros2bag_2_kitti_multiproc.pyscript.This multi-proc is relatively a drop in set of code with 2 primary functions:
display_progress_monitorandprocess_topic_wrapper. Theprocess_topic_wrapperis just a wrapper function around the generic bag reading code we already have, to be used withmultiprocessing. Thedisplay_progress_monitoris just a nicer CLI UI to show proc progress.Here's an example of the CLI output:
