Skip to content

fix view_chain_deploy command, add proper messages and implement the empty block check mechanism#49

Open
furkanahmetk wants to merge 3 commits intocasper-network:devfrom
furkanahmetk:view/chain/deploy
Open

fix view_chain_deploy command, add proper messages and implement the empty block check mechanism#49
furkanahmetk wants to merge 3 commits intocasper-network:devfrom
furkanahmetk:view/chain/deploy

Conversation

@furkanahmetk
Copy link
Contributor

Description

  • Fix nctl-view-chain-deploy command
  • Add empty block check mechanism for default usage(no paramater) of the command.
  • Make config for the latest client and node repos

Fixes #44

Type of change

  • [+] Bug fix
  • New feature
  • Breaking change
  • Documentation update

Testing

Describe how you tested your changes:

  • Commands run: nctl-view-chain-deploy
  • Network configuration: 10 nodes (6 active , 4 inactive) default chainspec of local casper-node.
  • Test results: Successful result rised, if there are no deploys on current block it raises the proper information message.

Checklist

  • [+] My code follows the project's style
  • [+] I have tested my changes
  • [+] I have updated documentation if needed
  • [+] All scripts execute without errors

…empty block check mechanism

Signed-off-by: Furkan Ahmet Kara <[email protected]>
Signed-off-by: Furkan Ahmet Kara <[email protected]>
@mrkara
Copy link
Contributor

mrkara commented Oct 25, 2025

@furkanahmetk Thank a lot for the PR! 🙏 We will review it and give feedback or merge it.

@darthsiroftardis or @sacherjj Could you please take a look?

@mrkara mrkara requested a review from sacherjj October 25, 2025 10:14
@darthsiroftardis
Copy link
Contributor

Can someone explain the use case for when a transaction hash is not specified

@mrkara
Copy link
Contributor

mrkara commented Oct 28, 2025

@darthsiroftardis No idea. Looks like an oversight to me.

@furkanahmetk Let's just:

  • Remove the no-parameter case
  • Make sure the command with a hash works fine

Signed-off-by: Furkan Ahmet Kara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[nctl-view-chain-deploy]

3 participants