misk-aws2-sqs: Auto-populate region from AWS environment#3669
Merged
notmikedavis merged 2 commits intocashapp:masterfrom Feb 12, 2026
Merged
misk-aws2-sqs: Auto-populate region from AWS environment#3669notmikedavis merged 2 commits intocashapp:masterfrom
notmikedavis merged 2 commits intocashapp:masterfrom
Conversation
…config Apply AWS environment default for region to dynamic config, matching the existing behavior for YAML config. This ensures dynamic config users don't need to explicitly specify region in their JSON config. Changes: - SubscriptionService now injects AwsRegion and applies it as a default after resolving the effective config (both YAML and dynamic) - Added tests for region auto-population with both YAML and dynamic config - Updated README to clarify that only region is auto-populated (account_id is optional and defaults to null, meaning AWS uses the caller's account)
notmikedavis
force-pushed
the
michaeld/sqsflag2
branch
from
9517b47 to
3ffb723
Compare
notmikedavis
changed the title
notmikedavis
changed the title
adrw
approved these changes
Feb 12, 2026
| * If a dynamic config flag is configured and returns a valid config, it completely replaces the YAML config. | ||
| * Otherwise, the YAML config is used. | ||
| * | ||
| * In both cases, if region is not specified in the config, it is populated from the AWS environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply AWS environment default for region to dynamic config, matching the
existing behavior for YAML config. This ensures dynamic config users don't
need to explicitly specify region in their JSON config.
Changes:
after resolving the effective config (both YAML and dynamic)
is optional and defaults to null, meaning AWS uses the caller's account)