Add redis_auth_username support to misk-redis-lettuce#3635
Open
davidjoyceAfterpay wants to merge 4 commits intocashapp:masterfrom
Open
Add redis_auth_username support to misk-redis-lettuce#3635davidjoyceAfterpay wants to merge 4 commits intocashapp:masterfrom
davidjoyceAfterpay wants to merge 4 commits intocashapp:masterfrom
Conversation
Redis 6.0+ introduced ACL with username+password authentication via the AUTH command. AWS ElastiCache with Redis ACL enabled requires both username and password for authentication. This change adds optional redis_auth_username field to: - RedisReplicationGroupConfig (standalone Redis) - RedisClusterGroupConfig (Redis Cluster) When username is provided, the Lettuce client uses withAuthentication() instead of withPassword() to pass both credentials. This is backwards compatible - when username is null, the existing password-only auth continues to work. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Tests verify that: - RedisReplicationGroupConfig accepts redis_auth_username - RedisClusterGroupConfig accepts redis_auth_username - Username defaults to null when not provided (backwards compatible) Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redis 6.0+ introduced ACL (Access Control List) with username+password authentication. AWS ElastiCache with Redis ACL enabled requires both username and password for authentication, but misk-redis-lettuce only supported password-only auth.
This PR adds:
redis_auth_usernamefield toRedisReplicationGroupConfig(standalone Redis)redis_auth_usernamefield toRedisClusterGroupConfig(Redis Cluster)withAuthentication(username, password)when username is providedwithPassword(password)when username is null (backwards compatible)Example Configuration
🤖 Generated with Claude Code