feat: remove linux/amd64 platform hardcoding#3620
Open
kevink-sq wants to merge 2 commits intocashapp:masterfrom
Open
feat: remove linux/amd64 platform hardcoding#3620kevink-sq wants to merge 2 commits intocashapp:masterfrom
linux/amd64 platform hardcoding#3620kevink-sq wants to merge 2 commits intocashapp:masterfrom
Conversation
adrw
approved these changes
Jan 8, 2026
| .createContainerCmd(vitessImage) | ||
| .withName(containerName) | ||
| .withHostConfig(hostConfig) | ||
| .withPlatform("linux/amd64") |
Collaborator
There was a problem hiding this comment.
What happens if this is removed? Does it fall back to some default ie. the platform that it's currently run on?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Looking to introduce an arm64 build of
vttestserverso need to remove the platform config as it prevents the arm image from starting up. Docker by default should look up the platform automatically on the host.Testing Strategy
Will follow up with testing internally since this is a test package.
Communication Plan
Consulted vitess team: slack
Thank you for contributing to Misk! 🎉