Open
Conversation
added 2 commits
August 6, 2019 16:38
adri09070
pushed a commit
to adri09070/DebuggableASTInterpreter
that referenced
this pull request
Sep 23, 2022
…d-because-the-AST-visitors-API-has-changed Fixing tests because of changes in AST variable nodes, as `RBGlobalNode` doesn't exist anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current #isTerminated method does not seem to work.
Running the following in a playground raises a "#isRoot was sent to nil" exception because the execution has reached the root context and is asking whether its parent (nil) is root to decide whether the execution is terminated.
This pull request make #isTerminated simply check whether the current context is the root context. With it, the example above runs without signalling an exception.