Add test for remove_item triggering needs_rebuild#59
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a test to verify that LSI#remove_item triggers the needs_rebuild? flag, completing the test coverage for issue #51.
- Adds
test_remove_item_triggers_needs_rebuildto validate that removing an item sets the rebuild flag - Complements existing tests for
remove_itemfunctionality added in PR #58 - Uses
auto_rebuild: falseto explicitly test theneeds_rebuild?state changes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ed81727 to
f2fa10c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the final missing test for issue #51 - verifying that
LSI#remove_itemtriggersneeds_rebuild?.Context
Most tests for
remove_itemanditemswere added in PR #58. This PR adds the one remaining test:remove_itembasic functionality (added in Add edge case tests for text handling #58)remove_itemon non-existent item (added in Add edge case tests for text handling #58)remove_itemtriggersneeds_rebuild?(this PR)itemsreturns list of indexed items (added in Add edge case tests for text handling #58)Test Added
Fixes #51