Conversation
The untrain method had zero test coverage, which was identified in the coverage audit (#48). This adds 11 tests covering: - Basic untrain functionality - Dynamic untrain_* method calls - Effect on classification results - Category count decrements - Word removal when count reaches zero - Partial word removal (multiple occurrences) - Edge case: untraining more than trained - Edge case: untraining non-existent words - Invalid category handling - Category word count updates Coverage improved from 88% to 91% line, 68% to 73% branch. Fixes #50
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for the previously untested Bayes#untrain method, improving line coverage by 3.33% and branch coverage by 4.72%.
Key Changes:
- Added 11 new test cases covering basic functionality, edge cases, and error handling
- Tests verify word count decrements, category updates, and classification impact
- Includes edge case handling for over-untraining and non-existent words
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
Re: Copilot's suggestion to change This is incorrect. The Porter stemmer keeps require 'fast-stemmer'
'word'.stem # => "word"
'unique'.stem # => "uniqu"
'apple'.stem # => "appl"The test is correct as written. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add comprehensive test coverage for the
Bayes#untrainmethod, which previously had zero coverage.Tests Added (11 total)
untrain_*method callsCoverage Improvement
Fixes #50