Merged
Conversation
Add test coverage tooling and document current coverage gaps. Current coverage: 88% line, 68% branch. Key findings: - Bayes#untrain method has zero coverage - LSI#remove_item and #items methods untested - Several edge cases missing across components Also includes sig folder in gem package for RBS distribution. Refs #48
There was a problem hiding this comment.
Pull request overview
This PR adds SimpleCov for test coverage tracking and provides a comprehensive audit of current test coverage gaps in the classifier gem. The audit reveals 88.06% line coverage and 67.92% branch coverage, identifying critical untested methods like Bayes#untrain, LSI#remove_item, and LSI#items.
Key changes:
- Integrated SimpleCov with branch coverage tracking and logical grouping of components
- Documented coverage gaps and created follow-up issues for critical missing tests
- Enhanced gem packaging to include RBS type signatures
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/test_helper.rb | Adds SimpleCov configuration with branch coverage and component grouping |
| classifier.gemspec | Updates file patterns to include sig folder and RBS type files in gem package |
| Gemfile | Adds SimpleCov as a test dependency |
| COVERAGE_AUDIT.md | Documents comprehensive coverage audit with identified gaps and recommendations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coverage Findings
Critical Gaps Identified
Follow-up Issues Created
Closes #48