Skip to content

feat: add config to specify executeProject key by environment variable#153

Merged
shydefoo merged 1 commit intomainfrom
add-execution-project-config
Jul 3, 2025
Merged

feat: add config to specify executeProject key by environment variable#153
shydefoo merged 1 commit intomainfrom
add-execution-project-config

Conversation

@shydefoo
Copy link
Collaborator

@shydefoo shydefoo commented Jun 30, 2025 •
edited
Loading

Summary

  • This MR is to allow users to specify datasources in a project different from the project that the SQL task will be executed in
  • In the jdbc url of the MaxcomputeSource, a new key executeProject is added, where the value is retrieved from the environment variable CARAML_SPARK_MAXCOMPUTE_EXECUTE_PROJECT
  • image

@shydefoo shydefoo self-assigned this Jun 30, 2025
@shydefoo shydefoo requested a review from anantadwi13 June 30, 2025 05:51
anantadwi13
anantadwi13 approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@anantadwi13 anantadwi13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shydefoo shydefoo merged commit 22be40d into main Jul 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anantadwi13 anantadwi13 anantadwi13 approved these changes

Assignees

@shydefoo shydefoo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shydefoo @anantadwi13